Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct required v.s. optional fields in run status #5819

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Correct required v.s. optional fields in run status #5819

merged 1 commit into from
Dec 23, 2022
+8 −16

Conversation

chuangw6
Copy link
Member

Changes

/kind misc

Fixes #5818.

Prior, startTime and completionTime are marked as optional fields in Run status, and provenance field was not marked as optional in Run status.

Now, we remove +optional tag for startTime and completionTime in Run status, and add +optional tag for the provenance field.

Signed-off-by: Chuang Wang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Remove optional tag for `startTime` and `completionTime` in TaskRun/PipelineRun status, and add option tag for `provenance` field in TaskRun/PipelineRun status.

@chuangw6
Correct required v.s. optional fields in run status
e8d6d50 
Fixes tektoncd#5818.

Prior, `startTime` and `completionTime` are marked as optional fields in Run
status, and `provenance` field was not marked as optional in Run status.

Now, we remove `+optional` tag for `startTime` and `completionTime` in Run
status, and add `+optional` tag for the `provenance` field.

Signed-off-by: Chuang Wang <[email protected]>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Nov 30, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2022
@chuangw6
Copy link
Member Author

cc @JeromeJu @dibyom @lbernick

Please take a look. Thanks!

@JeromeJu
Copy link
Member

JeromeJu commented Nov 30, 2022 •
edited
Loading

/retest
Flake: testReconcile/invalid-pipeline-run-missing-tasks-shd-stop-reconciling
link https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5819/pull-tekton-pipeline-unit-tests/1598068375232188416

JeromeJu
JeromeJu approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chuangw6 , nice catch!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
vdemeester
vdemeester approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu, lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 07598ee into tektoncd:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu approved these changes

@lbernick lbernick lbernick approved these changes

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency of Required v.s. Optional fields across docs.
6 participants
@chuangw6 @JeromeJu @tekton-robot @vdemeester @chitrangpatel @lbernick